Merged
Conversation
Collaborator
Potatoes3212
commented
Aug 1, 2025
Potatoes3212
commented
- В либу авторизации добавлена функция, получения user_id: get_current_user_id
- Удалено значение переменной по умолчанию Переменная
- В mypy добавлена проверка типизации контейнеров (dict[str, int])
This was referenced Aug 1, 2025
Kirill67tyar
approved these changes
Aug 1, 2025
Collaborator
Kirill67tyar
left a comment
Kirill67tyar
left a comment
There was a problem hiding this comment.
всё круто, хорошая шпаргалка для аннотаций, чтобы подсмотреть, как правильно)
|
|
||
| class NotificationRepository(BaseRepository): # noqa: WPS214 | ||
| class NotificationRepository(BaseRepository[Notification | MassNotification]): # noqa: WPS214 | ||
|
|
Collaborator
There was a problem hiding this comment.
Прикольно, не знал, что так тоже можно: some_type[some_t1 | some_t2]
| for message in messages: | ||
| if message.value is not None: | ||
| task = self._safe_message_handler( | ||
| for message in messages: # noqa: WPS220 |
Collaborator
There was a problem hiding this comment.
Правильно ли я понимаю, что # noqa: WPS220 из-за слишком глубокой вложенности?
Collaborator
Author
There was a problem hiding this comment.
Да. На это ругается. Надо будет переписать. Записал TODO выше.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.