Add constant time PropertyCollection#count
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
constant-time-count
branch
from
66fcb5a to
e244306
Compare
t6d
reviewed
Mar 26, 2021
| nil | ||
| end | ||
|
|
||
| def_delegators :@collection_with_parent_collection, :count, :size, :length, :values |
Owner
There was a problem hiding this comment.
Can you delegate to the reader rather than straight to the instance variable?
spec/property_collection_spec.rb
Outdated
| specify "PropertyCollection has O(1) #count" do | ||
| property_collection = Class.new(SmartProperties::PropertyCollection) do | ||
| def collection_with_parent_collection | ||
| mock('collection').expects(:count).once |
Owner
There was a problem hiding this comment.
Maybe we should add an additional return value and below assert for that:
mock('collection').expects(:count).once.returns(42)and
expect(property_collection.new.count).to eq(42)
And `#size` and `#length` to match `Hash`. Since I added `Forwardable` anyway, we can use it to replace the manual definition of `#values`
Now it tests more than just caching.
amomchilov
force-pushed
the
constant-time-count
branch
from
6e4bde2 to
b4ecfd5
Compare
Contributor
Author
|
Hmmm, I think this worked on my machine. I can't figure out how to trigger a rebuild, do you have any idea? @t6d |
Contributor
Author
|
Hey @t6d, just tidying up some old open PRs. Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and
#sizeand#length, to matchHash.Since I added
Forwardableanyway, we can use it to replace the manual definition of#values