Skip to content

[WIP][FEATURE] add new behat test setup environment#9

Closed
sakonachhoeurng wants to merge 1 commit intot3kit:masterfrom
sakonachhoeurng:behat-setup
Closed

[WIP][FEATURE] add new behat test setup environment#9
sakonachhoeurng wants to merge 1 commit intot3kit:masterfrom
sakonachhoeurng:behat-setup

Conversation

@sakonachhoeurng
Copy link
Copy Markdown

add behat test setup evironment

@sakonachhoeurng sakonachhoeurng changed the title [FEATURE] add new behat test setup evironment [FEATURE] add new behat test setup environment Dec 23, 2016
@sakonachhoeurng
Copy link
Copy Markdown
Author

@MattiasNilsson please review my merge request.
Thanks,

@MattiasNilsson
Copy link
Copy Markdown
Contributor

I really like that we are going to use Behat! But was I do not get is why we have behat test inside this repository? Shouldn´t the tests go into a repository where functionality exists? Also the tests are not really valid for this?

Two other things:

  • Install tool password is changed
  • Some states in PackageStates.php are changed

👍 For the behat part!

'debug' => false,
'explicitADmode' => 'explicitAllow',
'installToolPassword' => '$P$CoQoJHDiVRLGjuMQpOeAdPa6Vwag4o0',
'installToolPassword' => '$P$CFf7L8v6NduZTuMRfvPZVHdDqeJDTG1',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakonachhoeurng please check why the password has been changed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurisaarni I already reverted back to old password.
thanks for checking.

@sakonachhoeurng sakonachhoeurng force-pushed the behat-setup branch 2 times, most recently from ba89692 to 17c471c Compare January 3, 2017 06:55
@sakonachhoeurng
Copy link
Copy Markdown
Author

sakonachhoeurng commented Jan 3, 2017

@MattiasNilsson thanks for checking,
Reply to your question, Behat test folder why I add to this repository, because of I make uat on this website and for docker project.

  • tests folder need to add to your project directory
  • Behat cover test follow what has in website
  • install tool password I revert back to previous version
  • PackageState.php that revert up to date from branch master

I will make readme to make u can understand how to add behat test folder.

Copy link
Copy Markdown
Contributor

@MattiasNilsson MattiasNilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, there is just one small thing left to fix.

'DB' => [
'database' => 't3kit',
'host' => 'localhost',
'host' => 'db',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be localhost not db

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking,
I will update this one.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakonachhoeurng please test does this affect the functionality when running on Docker. It might not get connected with localhost.

cc: @MattiasNilsson

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakonachhoeurng Have you been able to try this one out yet?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry to late reply @laurisaarni, @MattiasNilsson I try it already, it does not work for docker. It should be db

@sakonachhoeurng sakonachhoeurng changed the title [FEATURE] add new behat test setup environment [WIP][FEATURE] add new behat test setup environment Jan 5, 2017
@sakonachhoeurng
Copy link
Copy Markdown
Author

this merge request close by update the new merge request #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants