[WIP][FEATURE] add new behat test setup environment#9
[WIP][FEATURE] add new behat test setup environment#9sakonachhoeurng wants to merge 1 commit intot3kit:masterfrom
Conversation
|
@MattiasNilsson please review my merge request. |
|
I really like that we are going to use Behat! But was I do not get is why we have behat test inside this repository? Shouldn´t the tests go into a repository where functionality exists? Also the tests are not really valid for this? Two other things:
👍 For the behat part! |
typo3conf/LocalConfiguration.php
Outdated
| 'debug' => false, | ||
| 'explicitADmode' => 'explicitAllow', | ||
| 'installToolPassword' => '$P$CoQoJHDiVRLGjuMQpOeAdPa6Vwag4o0', | ||
| 'installToolPassword' => '$P$CFf7L8v6NduZTuMRfvPZVHdDqeJDTG1', |
There was a problem hiding this comment.
@sakonachhoeurng please check why the password has been changed?
There was a problem hiding this comment.
@laurisaarni I already reverted back to old password.
thanks for checking.
ba89692 to
17c471c
Compare
|
@MattiasNilsson thanks for checking,
I will make readme to make u can understand how to add behat test folder. |
17c471c to
95978de
Compare
MattiasNilsson
left a comment
There was a problem hiding this comment.
Thanks for the fixes, there is just one small thing left to fix.
typo3conf/LocalConfiguration.php
Outdated
| 'DB' => [ | ||
| 'database' => 't3kit', | ||
| 'host' => 'localhost', | ||
| 'host' => 'db', |
There was a problem hiding this comment.
This needs to be localhost not db
There was a problem hiding this comment.
Thanks for checking,
I will update this one.
There was a problem hiding this comment.
@sakonachhoeurng please test does this affect the functionality when running on Docker. It might not get connected with localhost.
cc: @MattiasNilsson
There was a problem hiding this comment.
@sakonachhoeurng Have you been able to try this one out yet?
There was a problem hiding this comment.
I am sorry to late reply @laurisaarni, @MattiasNilsson I try it already, it does not work for docker. It should be db
95978de to
eab769e
Compare
|
this merge request close by update the new merge request #23 |
add behat test setup evironment