Open
Conversation
t1gor
requested changes
Aug 23, 2021
| * @param string $encoding - encoding | ||
| */ | ||
| public function __construct($content, $encoding = self::DEFAULT_ENCODING) | ||
| public function __construct($content, $encoding = self::DEFAULT_ENCODING, array $regExpPatternReplace = array()) |
Owner
There was a problem hiding this comment.
If you would like to pass in your own replaces, I guess it would make sense to merge our expected replaces with the user-ones, or at least pass the default ones by default:
Suggested change
| public function __construct($content, $encoding = self::DEFAULT_ENCODING, array $regExpPatternReplace = array()) | |
| public function __construct($content, $encoding = self::DEFAULT_ENCODING, array $regExpPatternReplace = array('@' => '\@')) |
| $this->prepareRules(); | ||
|
|
||
| $this->regExpPatternReplace = empty($regExpPatternReplace) | ||
| ? array('@' => '\@') |
Owner
There was a problem hiding this comment.
Are you sure you would want to replace it but not merge? Could you please provide a test for this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.