Pass boolean options to libcurl as long type #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a problem showing up in Ubuntu Resolute Raccoon
package builds on some architectures, such as amd64,
when int types are passed in:
In function ‘cinit’,
inlined from ‘main’ at main.c:138:6:
curl.c:69:13: error: call to ‘Wcurl_easy_setopt_err_long’ declared with attribute warning: curl_easy_setopt expects a long argument [-Werror=attribute-warning]
69 | if (curl_easy_setopt(*hdl, CURLOPT_VERBOSE, options.verbose)) {
| ^
curl.c:77:13: error: call to ‘Wcurl_easy_setopt_err_long’ declared with attribute warning: curl_easy_setopt expects a long argument [-Werror=attribute-warning]
77 | if (curl_easy_setopt(*hdl, CURLOPT_SSL_VERIFYPEER, options.verify)) {
| ^
curl.c:91:21: error: call to ‘Wcurl_easy_setopt_err_long’ declared with attribute warning: curl_easy_setopt expects a long argument [-Werror=attribute-warning]
91 | if (curl_easy_setopt(*hdl, CURLOPT_NETRC, options.netrc)) {
| ^
lto1: all warnings being treated as errors
<https://launchpadlibrarian.net/833438792/buildlog_ubuntu-resolute-amd64.mcds_1.9-4_BUILDING.txt.gz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem showing up in Ubuntu Resolute Raccoon package builds on some architectures, such as amd64, when int types are passed in:
https://launchpadlibrarian.net/833438792/buildlog_ubuntu-resolute-amd64.mcds_1.9-4_BUILDING.txt.gz
The warning seems to be correct, based on the man page. This error could cause incorrect behaviour and may have been the cause of instability in the Debian autopkgtest .netrc authentication test, which occasionally failed inexplicably.
I didn't work out how to trigger this warning in a standalone build or on Debian but did reproduce building the package in an Ubuntu development VM and tested the fix there.