Skip to content

[No Changes] Dependency conflict already resolved in PR #32#33

Merged
szincone merged 1 commit intomasterfrom
copilot/fix-dependency-resolution-error
Jan 29, 2026
Merged

[No Changes] Dependency conflict already resolved in PR #32#33
szincone merged 1 commit intomasterfrom
copilot/fix-dependency-resolution-error

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

Status

This branch contains no changes. The npm dependency conflict reported in workflow run 21466528992 was already fixed in PR #32 (commit b69cfa5).

Original Issue

@testing-library/react@16.3.0 (introduced in 4a8be0b) required @types/react@^18.0.0 || ^19.0.0, conflicting with the project's React 16.8.1 and @types/react@^16.9.53.

Resolution

PR #32 resolved this by:

  • Downgrading @testing-library/react to v12.1.5 (React 16 compatible)
  • Moving testing libraries to devDependencies
  • Downgrading @testing-library/jest-dom to v5.17.0

Master now passes CI (workflow run 21467193596 ✓).

Recommendation: Close this PR as obsolete.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/szincone/react-portfolio/commits
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Reference: https://github.com/szincone/react-portfolio/actions/runs/21466528992/job/61831744339
fix this
2026-01-29T05:46:41.2900374Z ##[debug]Evaluating condition for step: 'Install dependencies'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Install dependencies
##[debug]Loading inputs
##[debug]Loading env
Run npm ci
##[debug]/usr/bin/bash -e /home/runner/work/_temp/3012b9dd-5ec2-4f01-bc63-f88b57dbd26d.sh
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @testing-library/react@16.3.0
npm ERR! Found: @types/react@16.14.68
npm ERR! node_modules/@types/react
npm ERR! dev @types/react@"^16.9.53" from the root project
npm ERR! peerOptional @types/react@"^16.8.6 || ^17.0.0" from @material-ui/core@4.12.4
npm ERR! node_modules/@material-ui/core
npm ERR! @material-ui/core@"^4.12.4" from the root project
npm ERR! 7 more (@material-ui/styles, @material-ui/system, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional @types/react@"^18.0.0 || ^19.0.0" from @testing-library/react@16.3.0
npm ERR! node_modules/@testing-library/react
npm ERR! @testing-library/react@"^16.3.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @types/react@19.2.10
npm ERR! node_modules/@types/react
npm ERR! peerOptional @types/react@"^18.0.0 || ^19.0.0" from @testing-library/react@16.3.0
npm ERR! node_modules/@testing-library/react
npm ERR! @testing-library/react@"^16.3.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/runner/.npm/_logs/2026-01-29T05_46_41_521Z-debug-0.log
Process completed with exit code 1.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix dependency resolution error for npm install [No Changes] Dependency conflict already resolved in PR #32 Jan 29, 2026
Copilot AI requested a review from szincone January 29, 2026 05:53
@szincone szincone marked this pull request as ready for review January 29, 2026 05:53
@szincone szincone merged commit e5fce5e into master Jan 29, 2026
1 check passed
@szincone szincone deleted the copilot/fix-dependency-resolution-error branch January 29, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants