feature/asp-clingo

[lewashby]

Overview

This PR introduces two major enhancements to the MCP Solver framework:

1. Integration of Answer Set Programming (ASP) with Clingo
2. Support for Groq as an LLM provider

These changes expand the solver’s capabilities, improve flexibility for end-users, and modernize the LLM integration layer.

1. ASP/Clingo Integration

• New ASP Module:

Added a dedicated asp module under src/mcp_solver/asp/ for handling ASP-based problem solving.

• Clingo Backend:

Implemented Clingo as the primary ASP solver, including environment setup, model management, real-time syntax and grounding validation, and solution extraction.

• Testing:

Added test setups and example problems for ASP in the tests/problems/asp/ directory.

2. Groq LLM Provider Integration

• LLM Factory Update:

Extended the LLM factory to support Groq as an additional provider, alongside existing options.

Additional Notes

• Documentation:

Updated relevant documentation and instructions for both ASP/Clingo and Groq integration.

• Backward Compatibility:

All existing solvers and LLM providers remain supported; these changes are additive.

• Testing:

New and updated tests ensure coverage for the new features.

[lewashby]

Hello @szeider, I’ve submitted a pull request with some proposed changes related to your paper. I’d appreciate it if you could take a look when you have the time. Thank you!

[szeider]

Pull Request #7 Change Request

Thank you for this excellent contribution adding ASP/Clingo support! The integration is well-architected and follows the existing patterns nicely. Before merging, please address the following items:

Required Changes

1. Remove Groq LLM Integration
   Please remove all Groq-related changes to keep this PR focused on ASP/Clingo support only. This includes:

   • Remove langchain-groq from dependencies in pyproject.toml
   • Remove Groq references from src/mcp_solver/client/llm_factory.py
   • Remove GR/GQ platform code references from INSTALL.md and README.md
   • Remove Groq from CHANGELOG.md entry

   You're welcome to submit Groq support as a separate PR later, which would allow proper testing and review.

2. Fix syntax warning in src/mcp_solver/asp/error_handling.py:45

   # Current (causes SyntaxWarning):
   enhanced_message += f"\n\Here are more error details:\n{context}"
   
   # Please change to:
   enhanced_message += f"\nHere are more error details:\n{context}"

3. Test Problems Requirement
   Please replace the existing problems and provide exactly 6 ASP-specific problems in tests/problems/asp/ that showcase ASP's unique strengths:

   Remove current problems (too similar to existing solver problems):

   • simple_path_coloring.md - We already have graph coloring problems
   • university_course_scheduling.md - We already have scheduling problems

   Add 6 new ASP-specific problems:

   • test.md - A trivial test problem
   • 5 more problems that demonstrate ASP's unique capabilities (one must be UNSATISFIABLE)

   Suggested ASP-specific problems that other solvers can't handle well:

   • Default reasoning (e.g., "birds fly by default unless they are penguins")
   • Stable models with negation as failure (e.g., "eligible for discount unless explicitly excluded")
   • Recursive aggregates (e.g., company control through recursive ownership)
   • Weak constraints optimization (e.g., preference-based scheduling with :~ syntax)
   • Diagnostic reasoning (e.g., finding minimal fault explanations)
   • Frame problem (e.g., planning with inertia - things stay the same unless changed)
   • UNSAT example: Contradictory default rules or unstable program

   These problems should demonstrate features unique to ASP that are difficult or impossible to express in MiniZinc, PySAT, or Z3.

   Important Note: When adding problems with advanced ASP constructs (weak constraints :~, aggregates, defaults, etc.), please also update the prompts/asp/instructions.md file to include guidance and examples for these constructs. This will help the LLM agent effectively handle these advanced ASP features.

4. Code Quality
   Please run the following before final submission:

   uv run ruff format .
   uv run ruff check --fix .

   This will ensure consistent formatting and fix any linting issues.

Notes

• Once Groq is removed, this becomes a clean, single-feature PR for ASP/Clingo support
• The ASP implementation itself is excellent and ready to merge after these changes
• Consider submitting Groq support as a separate PR if desired

Thanks again for this valuable contribution to the project!