Skip to content

Comments

feat: Add Hebrew Git glossary term: add.md#1

Open
HodayaMoyal wants to merge 1 commit intoszabgab:mainfrom
HodayaMoyal:feature/glossary-add-md
Open

feat: Add Hebrew Git glossary term: add.md#1
HodayaMoyal wants to merge 1 commit intoszabgab:mainfrom
HodayaMoyal:feature/glossary-add-md

Conversation

@HodayaMoyal
Copy link

,
שלום גאבור
בהמשך לבקשתך, אני שולחת את קובץ המילון הראשון מתוך המילון המלא.
קובץ זה מוסיף את מונח "add" למילון המונחים בעברית.

את שאר קבצי המילון אשלח ב-Pull Requests נפרדים וקטנים יותר, כפי שהמלצת.

תודה, הודיה

@szabgab
Copy link
Owner

szabgab commented Jun 22, 2025

Thanks for the PR.
The files should be in a subfolder of the src folder so let's move them to src/glossary.
They should be also listed in the src/SUMMARY.md` file.
Please follow the instruction in the README file.
I'll comment on the content of the files separately.

@szabgab
Copy link
Owner

szabgab commented Jun 22, 2025

please reopen this and update this pr moving the files

@szabgab szabgab reopened this Jun 22, 2025
@szabgab
Copy link
Owner

szabgab commented Jun 22, 2025

I am thinking aloud as I am not sure what would be the best, but it feels strange that English words are mixed in the Hebrew text. It would be probably better if the text was fully in Hebrew and where it refers to some command all those words and expressions would be links to the definition of the respective word or expression.

For example instead of "commit" I might write "קומיט" and then link to the page explaining about "commit".

I also asked a friend who is a professional translator if he could add his suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants