Update README with virtio config and bridge setup instructions#90
Closed
CharleneChar wants to merge 2 commits intosysprog21:mainfrom
Closed
Update README with virtio config and bridge setup instructions#90CharleneChar wants to merge 2 commits intosysprog21:mainfrom
CharleneChar wants to merge 2 commits intosysprog21:mainfrom
Conversation
Add instructions to disable the virtio network driver so the virtio device can bind to the vwifi driver. Document the expected CONFIG setting in .config and provide menuconfig navigation steps. Also include steps to bring up the bridge device (br0) required for networking setup.
jserv
reviewed
Mar 30, 2026
| $ sudo ip link set tap2 master br0 | ||
| ``` | ||
|
|
||
| Start `bridge` device: |
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out. I’ve created PR #92 to address this issue, and I’ll follow up and resolve it in that PR.
jserv
reviewed
Mar 30, 2026
| $ make menuconfig | ||
| ``` | ||
| The default kernel configuration will work for our testing environment, so just click `save` and we get `.config` on the top directory. | ||
| To allow virtio device to be bound to vwifi driver, please ensure the virtio network driver is disabled before you click `save`. By excluding the virtio network driver, you should spot `CONFIG_VIRTIO_NET=n` in the `.config` file on the top directory. |
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out. I’ve created PR #92 to address this issue, and I’ll follow up and resolve it in that PR.
Add conditional compilation for kernel >= 6.17 to handle the updated cfg80211 tx power callbacks, which introduce the radio_idx parameter in set_tx_power() and get_tx_power(). Also preserve compatibility with earlier kernels by keeping existing signatures under appropriate LINUX_VERSION_CODE checks, including link_id handling introduced in 6.14. This fixes autobuild failures on newer kernel versions without affecting older versions.
jserv
requested changes
Apr 1, 2026
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Split code changes and documentation refinements into two pull requests.
Contributor
Author
Thanks for the review. I’ve split the changes into two separate PRs for clarity and easier review:
I’ll close this PR and continue the discussion in those threads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instructions to disable the virtio network driver so the virtio device can bind to the vwifi driver. Document the expected CONFIG setting in .config and provide menuconfig navigation steps.
Also include steps to bring up the bridge device (br0) required for networking setup.