Skip to content

Protocol encoding/decoding and utility unit tests (Phase 2.5) #5488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renecannao merged 3 commits into from
Mar 22, 2026
+431 −1

Address review feedback on protocol unit tests (PR #5488)

045ff26
Select commit
Loading
Failed to load commit list.
Merged

Protocol encoding/decoding and utility unit tests (Phase 2.5) #5488

Address review feedback on protocol unit tests (PR #5488)
045ff26
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 22, 2026 in 8m 59s

Quality Gate failed

Failed conditions
1 Security Hotspot
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 337 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Potential leak of memory pointed to by 'input2' 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0SMVVzJ3eRK4OmEYWe&open=AZ0SMVVzJ3eRK4OmEYWe&pullRequest=5488

Check failure on line 344 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Potential leak of memory pointed to by 'input3' 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0SMVVzJ3eRK4OmEYWf&open=AZ0SMVVzJ3eRK4OmEYWf&pullRequest=5488

Check failure on line 330 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Potential leak of memory pointed to by 'input1' 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0SMVVzJ3eRK4OmEYWd&open=AZ0SMVVzJ3eRK4OmEYWd&pullRequest=5488

Check failure on line 281 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0S2C3-TeeD3ppJ7Ead&open=AZ0S2C3-TeeD3ppJ7Ead&pullRequest=5488

Check failure on line 347 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0SMVVzJ3eRK4OmEYWc&open=AZ0SMVVzJ3eRK4OmEYWc&pullRequest=5488

Check failure on line 124 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "U" suffix to this constant, to make it explicitly "unsigned". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0SMVVzJ3eRK4OmEYWY&open=AZ0SMVVzJ3eRK4OmEYWY&pullRequest=5488

Check failure on line 333 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0SMVVzJ3eRK4OmEYWa&open=AZ0SMVVzJ3eRK4OmEYWa&pullRequest=5488

Check failure on line 289 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0S2C3-TeeD3ppJ7Eae&open=AZ0S2C3-TeeD3ppJ7Eae&pullRequest=5488

Check failure on line 294 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0S2C3-TeeD3ppJ7Eaf&open=AZ0S2C3-TeeD3ppJ7Eaf&pullRequest=5488

Check failure on line 340 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0SMVVzJ3eRK4OmEYWb&open=AZ0SMVVzJ3eRK4OmEYWb&pullRequest=5488

Check failure on line 317 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "free". 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0S2C3-TeeD3ppJ7Eah&open=AZ0S2C3-TeeD3ppJ7Eah&pullRequest=5488

Check failure on line 178 in test/tap/tests/unit/protocol_unit-t.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::size" to get the size of this array. 

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0SMVVzJ3eRK4OmEYWZ&open=AZ0SMVVzJ3eRK4OmEYWZ&pullRequest=5488
View more details on SonarQubeCloud