PostgreSQL Cluster Sync Fixes and Refactoring #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

renecannao wants to merge 46 commits into v3.0 from fix/postgresql-cluster-sync_2

+4,908 −1,157

Open

PostgreSQL Cluster Sync Fixes and Refactoring #5297

cluster: harden PostgreSQL cluster sync parity paths after real two-n…

SonarQubeCloud / SonarCloud Code Analysis failed Mar 18, 2026 in 9m 33s

Quality Gate failed

Failed conditions
1 Security Hotspot
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 432 in test/tap/tests/test_cluster_sync_pgsql-t.cpp

sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 33 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0Cvm9tQsj-WQT-CMUY&open=AZ0Cvm9tQsj-WQT-CMUY&pullRequest=5297

Check warning on line 341 in test/tap/tests/test_cluster_sync_pgsql-t.cpp

sonarqubecloud / SonarCloud Code Analysis

Hard-coded passwords are security-sensitive.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0Cvm9tQsj-WQT-CMUX&open=AZ0Cvm9tQsj-WQT-CMUX&pullRequest=5297

Check failure on line 207 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6W&open=AZyIP6PHDrCtm3eXUv6W&pullRequest=5297

Check failure on line 209 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6X&open=AZyIP6PHDrCtm3eXUv6X&pullRequest=5297

Check failure on line 211 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6Y&open=AZyIP6PHDrCtm3eXUv6Y&pullRequest=5297

Check failure on line 186 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6V&open=AZyIP6PHDrCtm3eXUv6V&pullRequest=5297

Check failure on line 108 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6S&open=AZyIP6PHDrCtm3eXUv6S&pullRequest=5297

Check failure on line 6 in include/proxysql_glovars.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PWDrCtm3eXUv6b&open=AZyIP6PWDrCtm3eXUv6b&pullRequest=5297

Check failure on line 630 in test/tap/tests/test_cluster_sync_pgsql-t.cpp

sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 50 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0Cvm9tQsj-WQT-CMUZ&open=AZ0Cvm9tQsj-WQT-CMUZ&pullRequest=5297

Check failure on line 213 in test/tap/tests/test_cluster_sync_pgsql-t.cpp

sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 28 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZ0Cvm9tQsj-WQT-CMUW&open=AZ0Cvm9tQsj-WQT-CMUW&pullRequest=5297

Check failure on line 212 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6Z&open=AZyIP6PHDrCtm3eXUv6Z&pullRequest=5297

Check failure on line 158 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6U&open=AZyIP6PHDrCtm3eXUv6U&pullRequest=5297

Check failure on line 666 in test/tap/tests/test_cluster_sync_pgsql-t.cpp

sonarqubecloud / SonarCloud Code Analysis

format string is not a string literal

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6LPDrCtm3eXUv6P&open=AZyIP6LPDrCtm3eXUv6P&pullRequest=5297

Check failure on line 133 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6T&open=AZyIP6PHDrCtm3eXUv6T&pullRequest=5297

Check failure on line 736 in include/ProxySQL_Cluster.hpp

sonarqubecloud / SonarCloud Code Analysis

Simplify the declaration of "target_array".

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6PHDrCtm3eXUv6a&open=AZyIP6PHDrCtm3eXUv6a&pullRequest=5297

Check failure on line 599 in test/tap/tests/test_cluster_sync_pgsql-t.cpp

sonarqubecloud / SonarCloud Code Analysis

format string is not a string literal

See more on https://sonarcloud.io/project/issues?id=sysown_proxysql&issues=AZyIP6LPDrCtm3eXUv6O&open=AZyIP6LPDrCtm3eXUv6O&pullRequest=5297

View more details on SonarQubeCloud