Ability to use a local proxysql binary in testing#4
Open
spachev wants to merge 3 commits intosysown:masterfrom
Open
Ability to use a local proxysql binary in testing#4spachev wants to merge 3 commits intosysown:masterfrom
spachev wants to merge 3 commits intosysown:masterfrom
Conversation
added 3 commits
April 13, 2020 16:40
…rchestrator because go version was 1.10, required 1.12. So I upgraded alpine image to the latest. After that I had to fix the file copy because the directory structure apparently changed between versions. docker-compose-init.bash is still giving me problems even after I had created a local alias for orchestrator-client, which with the new version apparently has been replaced with orchestrator cli. It fails on discover with MySQL access denied message printed previously. I have not yet investigated that, but at least docker-compose build succeeds and I can see orchestrator containers coming up and printing messages that suggest they are doing something.
… image with proxysql binary replaced with the locally build one if running with REBUILD_DOCKER=1 and if the binary exists - defaulting to ../proxysql/src/proxysql, but can be overrided with PROXYSQL_BIN setting. If running with defaults or if the binary does not exist, use the original renecannao/proxysql_205_pltx19:debian9 image.
|
Not against adding this, I can see how it can be useful so lets go ahead and merge. Would it be possible to use the official images rather than the ones from Rene and your own repository? These are updated on each release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored proxysql containers to use spachev/proxysql-debian-stretch image with proxysql binary replaced with the locally build one if running with REBUILD_DOCKER=1 and if the binary exists - defaulting to ../proxysql/src/proxysql, but can be overrided with PROXYSQL_BIN setting. If running with defaults or if the binary does not exist, use the original renecannao/proxysql_205_pltx19:debian9 image.