Skip to content

Fix email domain up domain case sensitive comparison #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
axfcampos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix email domain up domain case sensitive comparison #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/omniauth/microsoft_graph/domain_verifier.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def verify!
# This means while it's not suitable for consistently identifying a user
# (the domain might change), it is suitable for verifying membership in
# a given domain.
return true if email_domain == upn_domain ||
return true if email_domain.casecmp?(upn_domain) ||
skip_verification == true ||
(skip_verification.is_a?(Array) && skip_verification.include?(email_domain)) ||
domain_verified_jwt_claim
Expand Down
7 changes: 7 additions & 0 deletions spec/omniauth/microsoft_graph/domain_verifier_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@
it { is_expected.to be_truthy }
end

context 'when email domain and userPrincipalName domain match but have different casing' do
let(:email) { 'foo@example.com' }
let(:upn) { 'bar@EXAMPLE.COM' }

it { is_expected.to be_truthy }
end

context 'when domain validation is disabled' do
let(:options) { super().merge(skip_domain_verification: true) }

Expand Down