Skip to content

Conversation

@majiayu000
Copy link

Fixes #412

Changes

  • Add DeleteWorkflowCompletedCondition to Promise status when delete pipeline fails
  • Record a warning event on the Promise when delete pipeline fails
  • Follow the same pattern as Resource implementation (PR feat: handle failed resource delete pipelines #362)

Add DeleteWorkflowCompleted condition to Promise status when the delete
pipeline fails. This mirrors the existing implementation for Resources
(as per PR syntasso#362) and provides visibility into delete workflow failures.

The change:
- Sets DeleteWorkflowCompletedCondition to False when delete pipeline fails
- Records a warning event on the Promise
- Follows the existing pattern from dynamic_resource_request_controller

Fixes syntasso#412

Signed-off-by: majiayu000 <1835304752@qq.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add promise delete pipeline failed status condition

2 participants