Skip to content

feat: update promise and resource status condition when delete workflow is triggered #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majiayu000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: update promise and resource status condition when delete workflow is triggered #656

majiayu000 wants to merge 1 commit into from

Conversation

@majiayu000
Copy link

@majiayu000 majiayu000 commented Jan 1, 2026

Fixes #413

Changes

  • Add GetDeleteWorkflowCompletedConditionStatus and MarkDeleteWorkflowAsRunning functions in resourceutil
  • Update DeleteWorkflowCompleted condition to indicate pipelines are in progress when delete workflow starts
  • Follow the same pattern as ConfigureWorkflow condition handling

@majiayu000
feat: update DeleteWorkflowCompleted condition when delete workflow s…
267e061 
…tarts

Add support for updating the DeleteWorkflowCompleted status condition when
a delete workflow is triggered. This mirrors the existing behavior for
configure workflows, where the condition is set to False with reason
"PipelinesInProgress" when the workflow starts.

Changes:
- Add GetDeleteWorkflowCompletedConditionStatus() function
- Add MarkDeleteWorkflowAsRunning() function
- Add setDeleteWorkflowCompletedConditionStatus() in workflow reconciler
- Update createDeletePipeline() to set condition before creating the job
- Add test for the new condition update behavior

Signed-off-by: majiayu000 <1835304752@qq.com>
@CLAassistant
Copy link

CLAassistant commented Jan 1, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: update promise and resource status condition when delete workflow is triggered

2 participants

@majiayu000 @CLAassistant