Added navigation tabs and updated documentation#145
Conversation
jimmeryn
requested review from
lukasz-jazwa and
piotrblaszczyk
as code owners
jimmeryn
added
documentation
There was a problem hiding this comment.
Other files use css modules, this uses simple css, let's use css modules if possible
| @@ -0,0 +1,81 @@ | |||
| .nav-tabs-container { | |||
| --text-primary: #ffffff; | |||
There was a problem hiding this comment.
We need to use tokens from the library, not create new colors - tokens are optimized for dark & light mode, AI proposed following colors:
--text-primary: #ffffff -> var(--ax-txt-primary-white) or var(--ax-txt-primary-default)
--text-secondary: #8b949e -> var(--ax-txt-secondary-default)
--accent-blue: #58a6ff -> var(--ax-colors-acc1-400) or var(--ifm-color-primary)
--accent-blue-dim: rgba(...) -> var(--ax-colors-acc1-500-10)
--border-default: #30363d -> var(--ax-ui-stroke-primary-default) or var(--ax-colors-gray-650)
| { | ||
| id: 'ui-components', | ||
| label: 'Diagram and UI Components Quickstart', | ||
| href: 'https://www.overflow.dev/ui-components', |
There was a problem hiding this comment.
Can we use relative urls ? The same below - so it will work on any env
README.md
Outdated
|
|
||
| ```html | ||
| <html data-theme="light"> | ||
| <html data-theme="light"></html> |
There was a problem hiding this comment.
The previous version implied that this html tag is open, I prefer previous version
2 participants
No description provided.