Open
Conversation
the time this Engine runs, so I moved it into an :after block. This allows webrick to be detected. Also, the base_urls are being cached on SwaggerYard init, so they were ignoring SwaggerYard.config block in the Rails app initializer. Setting config.reload is one way to solve this, but another way is to simply clear the cache after engine initialization. since engine is marked :after, config has already occured in the Rails.app, so clearing the cache forces a reload of the correct baseurl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
searching for the root cause to #5 led me to a variety of things as the commit log shows.
you may want to cherrypick or advise on parts that make sense (like relative_url_root support) and others that don't.