Fix #10: Spread operator in useValue of provider doesn't work when us…#12
Open
jantilburgh wants to merge 2 commits intosyncrea:masterfrom
Open
Fix #10: Spread operator in useValue of provider doesn't work when us…#12jantilburgh wants to merge 2 commits intosyncrea:masterfrom
jantilburgh wants to merge 2 commits intosyncrea:masterfrom
Conversation
gionkunz
reviewed
Feb 18, 2018
| provide: _STORE_FORMS_CONFIG, | ||
| useValue: config | ||
| }, { | ||
| provide: STORE_FORMS_CONFIG, |
Member
There was a problem hiding this comment.
This seems weird... Isn't there any other more elegant solution for this problem?
Author
There was a problem hiding this comment.
Not that I know of, for example it's not possible to return a function expression in a decorator. Also checked other libraries and it looks like that they're using the same approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #10 where the STORE_FORMS_CONFIG will be null when using AOT. Also removed the providers from the NgModule definition since the
forRoot&forFeatureconvention is used.