Enhance FormDefinitionField with FormState#43
Open
miladvafaeifard wants to merge 1 commit intosyncrea:masterfrom
Open
Enhance FormDefinitionField with FormState#43miladvafaeifard wants to merge 1 commit intosyncrea:masterfrom
miladvafaeifard wants to merge 1 commit intosyncrea:masterfrom
Conversation
Member
|
Hi Milad Thanks for the PR. Can you quickly describe what you're trying to achieve with this change? It looks like other than the tests you have added, nothing internal is using this functionality. |
Author
|
Hi Gion, Sure, actually it is nothing to do with the internal with this change. but couldn't be allowed to set is there way can be done to disable at the initial creation? |
Author
|
I guess I should refactor a bit in this PR by replacing FormState with FormControlState imported from angular/forms. I guess it only is available for Angular 14.x.x above. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.