fixed mild Future Warning (and use reST for README) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed both setup*.py files - removed the explicit set CFLAGS advice from README
- Future Warning: comparison to `None` will result in an elementwise object comparison in the future (Replaced "== None" with "is None" and same for "!=" and "is not") - rebuilt .c file with cython 0.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Josh,
I fixed the comparisons in the standalone qcprot that I had also fixed a while back in MDAnalysis.
I also converted the README to a reST file, which displays more nicely on GitHub. Merging was bit messy and my rebase skills were inadequate to make the history nice so feel free to pick and choose what you like.
Oliver