Skip to content

fix: connector copy command should not require a runtime version arg #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthiasdv merged 1 commit into from
Nov 21, 2025
Merged

fix: connector copy command should not require a runtime version arg #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cli/connector_command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ type connectorCommand struct {
targetId string

runtime string
runtimeVersion string
envFileSetByUser bool
}

Expand All @@ -72,7 +71,6 @@ func ConfigureConnectorCommand(parentCmd commandHost, opts *Options) {
copyCmd := connectorCmd.Command("copy", "Copy a connector").Action(c.copyConnector)
copyCmd.Arg("id", "The id of the connector to copy").Required().StringVar(&c.id)
copyCmd.Arg("target-id", "The id of the new connector").Required().StringVar(&c.targetId)
copyCmd.Flag("runtime-version", "The runtime version for the new connector").Required().StringVar(&c.runtimeVersion)

deleteCmd := connectorCmd.Command("delete", "Delete a connector").Alias("rm").Action(c.removeConnector)
deleteCmd.Arg("connector", "The name of the connector").Required().StringVar(&c.id)
Expand Down Expand Up @@ -432,7 +430,7 @@ func (c *connectorCommand) copyConnector(context *fisk.ParseContext) error {
return nil
}

_, err = appCtx.Client.CreateConnector(c.targetId, conn.Description, conn.RuntimeId, c.runtimeVersion, convert.ConvertStepsFromSpec(convert.ConvertStepsToSpec(conn.Steps)), c.opts.Timeout)
_, err = appCtx.Client.CreateConnector(c.targetId, conn.Description, conn.RuntimeId, conn.RuntimeVersion, convert.ConvertStepsFromSpec(convert.ConvertStepsToSpec(conn.Steps)), c.opts.Timeout)
fisk.FatalIfError(err, "failed to create connector %s: %v", c.targetId, err)

fmt.Printf("Created connector %s\n", color.GreenString(c.targetId))
Expand Down
2 changes: 1 addition & 1 deletion cli/connector_command_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ func (c *connectorCommand) copyConnectorWithClient(appCtx *AppContext) error {
}

// Create the copy
copied, err := appCtx.Client.CreateConnector(c.targetId, connector.Description, connector.RuntimeId, c.runtimeVersion, connector.Steps, c.opts.Timeout)
copied, err := appCtx.Client.CreateConnector(c.targetId, connector.Description, connector.RuntimeId, connector.RuntimeVersion, connector.Steps, c.opts.Timeout)
if err != nil {
return fmt.Errorf("failed to create connector copy: %w", err)
}
Expand Down
7 changes: 4 additions & 3 deletions cli/connector_command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,10 @@ var _ = Describe("ConnectorCommand", func() {
It("should copy a connector", func() {
// First it gets the source connector
mockCl.connector = &model.Connector{
ConnectorId: "source-connector",
Description: "Source Connector",
RuntimeId: "synadia",
ConnectorId: "source-connector",
Description: "Source Connector",
RuntimeId: "synadia",
RuntimeVersion: "v1.0.0",
Steps: model.Steps{
Source: &model.SourceStep{
Type: "generate",
Expand Down