-
-
Notifications
You must be signed in to change notification settings - Fork 166
Drop Symfony 6.4 support, require ^7.3|^8.0 #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chr-hertel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for rolling that out - there should also be some code that I annotated with 6.4 comments - but can easily remove that in a follow up
fb2605a to
6080ad7
Compare
|
Why do we want to drop 6.4? I don't think there is a big burden to support it and it it a huge benefit for adoption of we keep it. Or am I missing something? |
If you're not able to upgrade to a non-LTS version of Symfony, you will probably not be able to use Symfony AI, which is not stable yet (and probably not before the release of 7.4 LTS), you will probably not be able to upgrade Symony AI frequently which is going to be needed as the space is changing fast. |
xabbuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CI failures look related
yes, but I think this is due to the fact that not all Symfony components allow 7.4|8 ? just my guess |
6080ad7 to
b332a57
Compare
No, it's because you're pinning to unstable Symfony branches while requesting stable dependencies. |
|
Ok, so we can only merge this, once 7.4 and 8.0 are released? |
|
No, you'll have to lower the minimum stability to dev. Either globally for the project (as we do on symfony/symfony) or on those two CI jobs. |
|
👎 from me (at least until 7.4 is out). This will change a one-week proof-of-concept to a bigger "upgrade symfony" project for many companies – assuming that companies prefer LTS (yet are fine running |
b332a57 to
29e1a88
Compare
29e1a88 to
d045c2c
Compare
|
@derrabus I now use the proposed minimum stability and the 7.4 build is passing, but the 8.0 one not 🤔 |
bb2013a to
34a4033
Compare
|
@OskarStark Read the error message. ✌️ You need to run the Symfony 8 workflow on PHP 8.4. |
|
Thought I pushed it already |
5b8a29f to
7ce03af
Compare
### What: - [ ] Bug Fix - [x] New Feature ### Description: allow the package to be used with version 8 of Symfony components ### Related: Widening the accepted releases of the Symfony Console component will allow us to already test the Symfony AI packages with the upcoming Symfony 8 major release (see symfony/ai#277)
7ce03af to
e75995b
Compare
c5e91f1 to
c0d7d52
Compare
cd6b1c4 to
9574f3a
Compare
…` (OskarStark) This PR was merged into the main branch. Discussion ---------- [Examples] Add `minimum-stability` `dev` to `composer.json` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | -- | License | MIT Adds minimum-stability configuration to allow dev dependencies and development versions of packages in examples. Needed for #277, thanks `@xabbuh` Commits ------- f352744 [Examples] Add minimum-stability dev to composer.json
6ba655c to
d7f9a2b
Compare
d7f9a2b to
b9dd575
Compare
…tring configuration values (OskarStark) This PR was squashed before being merged into the main branch. Discussion ---------- [AI Bundle] Use `stringNode()` and `integerNode()` for string configuration values | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | -- | License | MIT Replace `scalarNode()` with more specific node types for better configuration type validation: - Use `stringNode()` for string values (API keys, URLs, service names, etc.) - Use `integerNode()` for integer values (dimensions, etc.) - Keep `scalarNode()` only for mixed-type fields where appropriate This provides better type validation and makes the configuration more self-documenting. ## Changes Made - **String fields**: API keys, URLs, endpoints, service names, class names, database/collection names, etc. now use `stringNode()` - **Integer fields**: `dimensions` and `top_k` fields now use `integerNode()` - **Mixed fields**: Strategy, metric, and similar fields remain as `scalarNode()` ## Needs - [ ] #277 Commits ------- 492f75f [AI Bundle] Use `stringNode()` and `integerNode()` for string configuration values
Needs
^CodeWithKyrian/platform-package-installer#4