This repository was archived by the owner on Jun 10, 2022. It is now read-only.
Open
Conversation
|
This pull request introduces 1 alert when merging 281025d into 5a6fbc1 - view on LGTM.com new alerts:
|
|
This pull request fixes 1 alert when merging 42c0582 into c3923fa - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables creating a profile connected to ledger speculos simulator(https://github.com/LedgerHQ/speculos). I think it's useful for speed up development, to test when you don't have a device or for possible e2e automatic testing if you can press the buttons with the simulator driver.
I'm between 2 minds on this one. Most of us have a ledger device but something like this would be useful for the Trezor development as we can use the simulator there too