Skip to content

Conversation

@AnthonyLaw
Copy link
Member

Problem: I noticed that the block info included beneficiary and totalFee properties, but they are not mentioned in the NEM docs.
Solution: Added beneficiary and totalFee, which makes it possible to calculate harvested fees directly instead of calculating from the transactions.

@AnthonyLaw AnthonyLaw requested a review from Wayonb January 19, 2026 17:36
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.87%. Comparing base (c187157) to head (df897c1).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1901      +/-   ##
==========================================
+ Coverage   96.14%   96.87%   +0.73%     
==========================================
  Files         343      261      -82     
  Lines       23803    19118    -4685     
  Branches      402      215     -187     
==========================================
- Hits        22885    18521    -4364     
+ Misses        905      591     -314     
+ Partials       13        6       -7     
Flag Coverage Δ
explorer-rest ?
lightapi-python 98.67% <100.00%> (+<0.01%) ⬆️
wallet-mobile-symbol ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pi/python/symbollightapi/connector/NemConnector.py 100.00% <ø> (ø)
lightapi/python/symbollightapi/model/Block.py 100.00% <100.00%> (ø)

... and 82 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@AnthonyLaw AnthonyLaw merged commit 9b6afea into dev Jan 22, 2026
22 checks passed
@AnthonyLaw AnthonyLaw deleted the lightapi/add-properties-in-block branch January 22, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants