First version of backend by fboucquez · Pull Request #19 · symbol/garush

fboucquez · 2021-12-21T23:03:11Z

Includes first versions of:

nextjs backend
configuration
bullmq
postgres
sequalize-typescript
logger
docker-compose with third-party services
file and art entities
graphql
rest/openapi

rxjs 7.4.0 upgrade/ SDK upgrade
few storage improvements

Added search service.

lgtm-com · 2021-12-21T23:12:31Z

This pull request introduces 2 alerts when merging bc1d2d2 into 4d5d126 - view on LGTM.com

new alerts:

2 for Missing await

segfaultxavi · 2021-12-22T08:23:31Z

README.md

+- http://localhost:3000 - Garush Backend.
+- http://localhost:3001 - Garush Frontend.


Aren't these ports used by Symbol nodes? Can't we have a Garush server and a Symbol node on the same machine?

These are ports used for the local services while on development. On production, those services would have their own hostname and they will run on port 443 (HTTPS). Garush doesn't run any symbol node, it connects to them like any other app.

README.md

segfaultxavi · 2021-12-22T08:26:03Z

README.md

+The first time your run the services, you need to create the minio/s3 access key.
+
+Go to the Minio Console's user tab
+
+http://localhost:9001/users (`minioadmin:minioadmin`)
+
+And create a user with access and key `minioadmin1:minioadmin1`. These keys are the backend's default.
+
+Give this user all the permissions. TODO: Automatize the minio/s3 token for local development


Suggested change

The first time your run the services, you need to create the minio/s3 access key.

Go to the Minio Console's user tab

http://localhost:9001/users (`minioadmin:minioadmin`)

And create a user with access and key `minioadmin1:minioadmin1`. These keys are the backend's default.

Give this user all the permissions. TODO: Automatize the minio/s3 token for local development

The first time you run the services, you need to create the minio/s3 access key:

- Go to the Minio Console's user tab: http://localhost:9001/users (`minioadmin:minioadmin`)

- Create a user with access and key `minioadmin1:minioadmin1`. These keys are the backend's default.

- Give this user all the permissions. TODO: Automatize the minio/s3 token for local development

segfaultxavi · 2021-12-22T08:26:51Z

README.md

+- http://localhost:3000/art
+- http://localhost:3000/file
+
+The bullmq job would be populating the database and s3 bucket from the symbol and garush networks.


Suggested change

The bullmq job would be populating the database and s3 bucket from the symbol and garush networks.

The `bullmq` job will be populating the database and s3 bucket from the Symbol and Garush networks.

yilmazbahadir

Good work mate! Added a couple of small comments.

packages/backend/src/modules/art/art.service.ts

yilmazbahadir · 2021-12-22T11:22:52Z

packages/backend/src/modules/art/art.job.ts

+@Processor('garush')
+export class ArtJobService {
+    constructor(@InjectQueue('garush') private queue: Queue, @Inject(ArtService) private readonly artService: ArtService) {
+        queue.add('refresh_art', {}, { repeat: { every: 60000 } });


should be better to extract this to the configuration

Basic extraction is done. We may want to extend the configuration so we can find grain the jobs, like every vs cron configuration, or add some custom job-specific param.

yilmazbahadir · 2021-12-22T11:42:32Z

packages/backend/src/modules/art/art.service.ts

+        });
+
+        if (isObservable(artSubscriber)) {
+            // I have hacked this with  "rxjs": "file:../storage/node_modules/rxjs",


Is this compatibility issue still stands if it's the same rxjs version? It used to be a peer dependency in nestjs previously but not now I guess.

storage -> rxjs 7.4.0 in their own node_modules
backend -> rxjs 7.4.0 in their own node_modules.

Both rxjs folders are different. When the backed tries to use an Observable created on storage, the rxjs on the backend raises an error thinking it's not observable. Basically this check fails

https://github.com/ReactiveX/rxjs/blob/master/src/internal/observable/innerFrom.ts#L16
raising
https://github.com/ReactiveX/rxjs/blob/master/src/internal/util/throwUnobservableError.ts#L8

This is not a version issue as everything is 7.4.0, but the instances are different. I think we should find a way that shared third part modules should be installed in a shared folder, I believe learn could fix that. Having said that, this seems to be a common problem, there should be npm solution for it.

yilmazbahadir · 2021-12-22T13:32:02Z

packages/backend/src/common/network.ts

@@ -0,0 +1,11 @@
+export enum Network {


You must have picked the name Network so that it doesn't clash with SDK/NetworkType, I guess. But it is not too clear that it's an enum by looking at the references. Should we find a different name like NFTNetworkType or a better one?

Network is the identifier of a given network in the env, not its type. The garush solution uses 2 networks, the garush network (pre-sell) and the symbol network (after sold and resells). In my mind:

Dev env:
Garush = garush.dev -> testnet network type
Symbol = joeynet -> testnet network type

Prod env
Garush = a new garush network? -> testnet/mainnet? network type
Symbol = mainnet -> mainnet network type

You can notice that both dev networks use the same network type (with T prefixed addresses), Network is not the same as network type.

We would have 2 running garush, a test env, and a prod env.

Yea I can see Network and the SDK/NetworkType are not the same, what I meant was the name Network implies (to me) an object rather than an enum/identifier that's why I asked.

Any recommendation? should we go with NFTNetworkType?

lgtm-com · 2021-12-22T21:25:27Z

This pull request introduces 1 alert when merging 06684a7 into 4d5d126 - view on LGTM.com

new alerts:

1 for Missing await

Fix art refresh job. Some improvements Fixed unique index Improved logging

Fernando added 2 commits December 13, 2021 13:55

working on nest-js

14467fc

Added search service.

First version sequalize

bc1d2d2

fboucquez requested a review from yilmazbahadir December 21, 2021 23:04

segfaultxavi reviewed Dec 22, 2021

View reviewed changes

yilmazbahadir reviewed Dec 22, 2021

View reviewed changes

fboucquez requested review from segfaultxavi and yilmazbahadir December 22, 2021 21:26

Feedback fixes

5dfe042

Fix art refresh job. Some improvements Fixed unique index Improved logging

fboucquez force-pushed the sequelize branch from 06684a7 to 5dfe042 Compare December 22, 2021 21:34

		- http://localhost:3000 - Garush Backend.
		- http://localhost:3001 - Garush Frontend.

	The bullmq job would be populating the database and s3 bucket from the symbol and garush networks.
	The `bullmq` job will be populating the database and s3 bucket from the Symbol and Garush networks.

Conversation

fboucquez commented Dec 21, 2021

Uh oh!

lgtm-com bot commented Dec 21, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yilmazbahadir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fboucquez Dec 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fboucquez Dec 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Dec 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fboucquez Dec 22, 2021 •

edited

Loading

fboucquez Dec 23, 2021 •

edited

Loading