Skip to content

feat: respect data-swup-no-preload for preloadHoveredLinks/preloadVisibleLinks #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleclarson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: respect data-swup-no-preload for preloadHoveredLinks/preloadVisibleLinks #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ export default class SwupPreloadPlugin extends Plugin {

const el = event.delegateTarget;
if (!isAnchorElement(el)) return;
if (el.hasAttribute('data-swup-no-preload')) return;

// Create temporary visit object for link:hover hook
const { url: to, hash } = Location.fromElement(el);
Expand Down Expand Up @@ -371,11 +372,13 @@ export default class SwupPreloadPlugin extends Plugin {
const { threshold, delay, containers } = this.options.preloadVisibleLinks;
const callback = (el: AnchorElement) => this.preload(el);
const filter = (el: AnchorElement) => {
/** First, run the custom callback */
if (this.options.preloadVisibleLinks.ignore(el)) return false;
/** First, look for opt-out attribute */
if (el.hasAttribute('data-swup-no-preload')) return false;
/** Second, check if it's a valid swup link */
if (!el.matches(this.swup.options.linkSelector)) return false;
/** Third, run all default checks */
/** Third, run the custom callback */
if (this.options.preloadVisibleLinks.ignore(el)) return false;
/** Fourth, run all default checks */
const { href } = Location.fromElement(el);
return this.shouldPreload(href, { el });
};
Expand Down
Loading