Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,23 @@ test.concurrent('test sync event listenerCount', () => {
expect(eventEmitter.listenerCount('ev1')).toBe(0)
})

test('offAll should remove listener options for specific event', () => {
jest.useFakeTimers()
const eventEmitter = SyncEvent.new<EventHandlerMap>()
const handler = jest.fn()

eventEmitter.on('ev1', handler, { debounce: { waitMs: 50 } })
eventEmitter.offAll('ev1')

eventEmitter.on('ev1', handler)
eventEmitter.emit('ev1', '', 1)
eventEmitter.emit('ev1', '', 1)
jest.advanceTimersByTime(100)

expect(handler).toHaveBeenCalledTimes(2)
jest.useRealTimers()
})

test.concurrent('test sync event on and once', () => {
const eventEmitter = SyncEvent.new<EventHandlerMap>()
let count = 0
Expand Down
19 changes: 16 additions & 3 deletions src/sync-event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,25 @@ export class SyncEvent<M extends HandlerMap> implements ISyncEvent<M> {
*/
public offAll = <K extends keyof M>(event?: K): this => {
if (event) {
// FIXME memory leak
this.#listenerCount -= this.#handlerMap.delete(event)?.size ?? 0
this.#handlerMap.set(event, new CollectionSet())
const handlers = this.#handlerMap.delete(event)
if (handlers) {
this.#listenerCount -= handlers.size

handlers.forEach(handler => {
this.#listenerConfigMap.delete(handler)
})

this.#onceHandlerWrapperMap.forEach((wrapper, origin) => {
if (wrapper.type === event) {
this.#onceHandlerWrapperMap.delete(origin)
}
})
}
} else {
this.#handlerMap.clear()
this.#onceHandlerWrapperMap.clear()
this.#anyHandlerSet.clear()
this.#listenerConfigMap.clear()
this.#listenerCount = 0
}

Expand All @@ -239,6 +251,7 @@ export class SyncEvent<M extends HandlerMap> implements ISyncEvent<M> {
const successDeleted = handlers.delete(handler)
if (successDeleted) {
this.#listenerCount -= 1
this.#listenerConfigMap.delete(handler)
}
}

Expand Down