Allow specification of never using hash routes #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some folks might not want to use hash routes, even if the browser doesn't support push state. This adds an option to fallback to full page refreshes upon calls to `navigate`.
Contributor
Author
|
So, still need a commit to fix that link/root situation, and to fix these tests. Curious what y'all think though. |
Contributor
There was a problem hiding this comment.
this.pushStateEnabled || this.fallbackToHashRoutes could probably be refactored into a function since it's now used so much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some folks might not want to use hash routes, even if the browser doesn't support push state. So I've added a change such that you can specify
fallbackToHashRoutesasfalse. Specifying this option means:Aviator.dispatch()would still perform the right action based on the url, but calls tonavigatetrigger full page refreshes, links work as normal, and Aviator doesn't intercept calls to the back button.With this commit, we are skipping the whole
_attachEventsstep. To actually have links work as normal, when a root is specified, we need to actually still interceptnavigatelink clicks so as to prepend the root.@barnabyc @hojberg @nahiluhmot