fix init naming mismatch #502 + tests #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java's `init` methods are bridged as is and made swift compatible
via the backticks.
At runtime though, this is forgotten and the java methods are looked up
_with_ the backticks.
This approach of fixing adds a `@JavaMethod("init")` annotation, which fixes
the issue.
(Though I'm not sure if this shouldn't be fixed in the generated macro code.
Open for suggestions!)
ktoso
force-pushed
the
bugfix/init-methods
branch
from
dcdf4bb to
a6ec455
Compare
Contributor
|
Thanks @ktoso! 🙏 |
Collaborator
Author
It's a test I've added to see these actually working at runtime, but I've been battling test issues with the JVM teardown so the body moved to the mangling one... I'll finish this up tonight probably |
ktoso
force-pushed
the
bugfix/init-methods
branch
from
319149a to
afdfec2
Compare
ktoso
force-pushed
the
bugfix/init-methods
branch
from
afdfec2 to
64a5d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to the #502 and some cleanup
Will retain credit to @diederich ofc, thank you!