remove SocketAddress.make(from:) protocol #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
SocketAddress.make(from:)from protocol and instead place the methods on the 3 address types;sockaddr_insockaddr_in6sockaddr_unOther conformers cannot be converted from
sockaddr_storageusing the current methods so it makes sense to have the compiler enforce this.Updates
sockaddr_strorage.withSockAddr { }to pass the underlying address size, not the storage size.