Add comprehensive comparison of intensity.py between current and tng_grism branches#34
Draft
Add comprehensive comparison of intensity.py between current and tng_grism branches#34
Conversation
Co-authored-by: JiachuanXu <29830404+JiachuanXu@users.noreply.github.com>
Co-authored-by: JiachuanXu <29830404+JiachuanXu@users.noreply.github.com>
Co-authored-by: JiachuanXu <29830404+JiachuanXu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Compare intensity.py with tng_grism branch
Add comprehensive comparison of intensity.py between current and tng_grism branches
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compares
kl_tools/intensity.pyimplementations across branches to document architectural evolution and guide branch selection.Summary Document
Created
INTENSITY_COMPARISON.mdcovering:ImageParsabstraction with dependency injection;tng_grismuses direct datacube couplingIntensityMap,InclinedExponential,BasisIntensityMap,IntensityMapFitter) differ significantly in constructor signatures and render methodsCompositeIntensityMapfor exp+basis models;tng_grismaddsGMixModelstubtng_grismdesigned for multi-line spectroscopy with per-line morphologyKey Distinctions
Current branch (~1,279 lines):
tng_grism branch (~1,275 lines):
Document includes migration path, usage recommendations, and detailed change breakdown across ~750 modified lines.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.