Open
Conversation
Added FeatureEntryPoint to actionPerformed in deleteAction
entrypoint added to my feature
…jhotdraw-utils to have a dependency on the feature tracer so that it can be ued within the module.
Inserted Featuretracer for undo refactoring and modified pom.xml for …
fix feature entry point
Feature/3/edit rectangle
A super class UndoRedoAction.java, has been extracted form UndoAction.java and RedoAction.java to define common behaviour. This involves the introduction of a new method to define id and pass them to the super constructor to include in inherited behaviour.
Ids are now stored, edited and accessed through the ActionIDs.java enum class.
"labels" variable in UndoAction.java and RedoAction.java has been made local, "id" in UndoRedoAction.java has been made final to prevent altering and unsed imports have been cleaned.
Added correct modifier to getID()
Removed faulty condition.
It is now a lamda instead of an anonumous inner class and is transient and dinal.
Redo undo klaes
All the work I've done, essentially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.