presentation-time: use a surface addon #3246
Conversation
vyivel
force-pushed
the
presentation-time-refactor
branch
2 times, most recently
from
4d91d85 to
b72f094
Compare
|
Rebased against master. |
emersion
left a comment
emersion
left a comment
There was a problem hiding this comment.
This is a very nice simplification and optimization! Apart from the presented flag, this LGTM.
| @@ -31,27 +31,15 @@ struct wlr_presentation { | |||
|
|
|||
| struct wlr_presentation_feedback { | |||
| struct wlr_presentation *presentation; | |||
There was a problem hiding this comment.
Unrelated to this PR, but this field seems to be unused?
There was a problem hiding this comment.
Other wlroots objects seem to have a pointer to the "main" object as well (e.g. wlr_layer_surface_v1 has a pointer to the corresponding wlr_layer_shell_v1). Maybe compositors could use it, idk.
There was a problem hiding this comment.
Some other wlroots objects have it because they need it. I don't think it's useful for compositors.
There was a problem hiding this comment.
(In any case, this is just a drive-by comment, not something that should be addressed in this PR.)
vyivel
force-pushed
the
presentation-time-refactor
branch
from
b72f094 to
f0f96c4
Compare
2 participants
Preliminary work for #3151.
This PR introduces a surface-synced object which acts as an "owner" of presentation feedbacks, which allows switching to the usual
current/pendingpattern.Notes
wlr_presentation_surfacewithout destroying the surface itself, it shouldn't be a problem as a surface which uses presentation feedbacks is likely to use them for its entire lifetime.weston-presentation-shm.