This repository was archived by the owner on Nov 1, 2021. It is now read-only.
render: drop libEGL dependency if gles2 is disabled#3241
Open
jbeich wants to merge 1 commit intoswaywm:masterfrom
jbeich:no-egl
Open
render: drop libEGL dependency if gles2 is disabled#3241jbeich wants to merge 1 commit intoswaywm:masterfrom jbeich:no-egl
jbeich wants to merge 1 commit intoswaywm:masterfrom
jbeich:no-egl
Conversation
emersion
reviewed
Oct 5, 2021
render/meson.build
Outdated
| egl = dependency('egl', required: 'gles2' in renderers) | ||
| if egl.found() | ||
| if 'gles2' in renderers or 'auto' in renderers | ||
| egl = dependency('egl') |
Member
There was a problem hiding this comment.
Hm, this isn't quite right. If running with auto, we'll want to look for the egl dep, and disable the gles2 renderer if it's missing. Here the egl dep is mandatory.
Member
There was a problem hiding this comment.
FWIW, I think we just need to wrap the original code as-is in the if 'gles2' in renderers or 'auto' in renderers condition you've added above and it should be good to go.
For `required` to disable search the value needs to be of `feature` type. Checking `gles2` via `in` keyword returns a `bool` but `required: false` makes the dependency optional instead of disabled.
Member
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling
gles2currently violates reproducibility due to opportunistic lookup of libEGL even when auto-detection is disabled.