This repository was archived by the owner on Nov 1, 2021. It is now read-only.
xdg-shell: drop wlr_xdg_toplevel_set_fullscreen_event#3229
Open
vyivel wants to merge 2 commits intoswaywm:masterfrom
Open
xdg-shell: drop wlr_xdg_toplevel_set_fullscreen_event#3229vyivel wants to merge 2 commits intoswaywm:masterfrom
vyivel wants to merge 2 commits intoswaywm:masterfrom
Conversation
Member
|
Not sure we want this. |
added 2 commits
October 1, 2021 16:43
The requested properties can be read by compositors on any relevant event (set_maximized, set_fullscreen etc), not just surface map. Reading `minimized` only makes sense on surface map, as the compositor can't handle set_minimized events before that.
Instead, compositors can read relevant values from wlr_xdg_toplevel.requested.
vyivel
force-pushed
the
xdg-toplevel-nuke-fullscreen-event
branch
from
97c9b2e to
7832482
Compare
Member
Author
|
Why not? |
emersion
reviewed
Oct 7, 2021
| }; | ||
|
|
||
| wlr_signal_emit_safe(&surface->toplevel->events.request_fullscreen, &event); | ||
| wlr_signal_emit_safe(&surface->toplevel->events.request_fullscreen, surface); |
Member
There was a problem hiding this comment.
I'd prefer to avoid introducing more cases where we use surface as the signal data pointer, for the reasons described in #1008 (comment).
Member
|
It's one of these cases where I'm not sure the breaking changes are worth the effort. Much like @ifreund's "borderline bikeshedding" patch series. I'm not feeling strongly about this. |
Member
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, compositors can read relevant values from wlr_xdg_toplevel.requested.
This is a breaking change:
wlr_xdg_toplevel.events.set_fullscreenlisteners now receive awlr_xdg_surfaceand are supposed to readwlr_xdg_toplevel.requested.fullscreen{,_output}.