This repository was archived by the owner on Nov 1, 2021. It is now read-only.
surface: improve role precommit hook, add commit_request signal#3191
Draft
vyivel wants to merge 3 commits intoswaywm:masterfrom
Draft
surface: improve role precommit hook, add commit_request signal#3191vyivel wants to merge 3 commits intoswaywm:masterfrom
vyivel wants to merge 3 commits intoswaywm:masterfrom
Conversation
Member
Author
|
|
added 3 commits
October 4, 2021 22:46
Now the role precommit hook is called before the commit, not on wl_surface.commit request, and takes a state which is to be applied.
vyivel
changed the title
vyivel
changed the title
Member
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
Makes
precommitbeing called before the actual commit. Preliminary work for a future PR decoupling subsurface code fromwlr_surface.