This repository was archived by the owner on Nov 1, 2021. It is now read-only.
Merged
Conversation
Caching frame callback lists is actually the correct behavior, because if a surface is locked because of e.g. subsurface synchronization, clients would expect to receive frame done events only after the pending state is actually committed.
Add a comment to explain the difference.
Move the wlr_subsurface parent link to the subsurface state. This is a dumb find/replace operation. This shouldn't result in any behavior change.
This makes the naming consistent with other resource implementations.
This was referenced Sep 6, 2021
This was referenced Sep 6, 2021
Open
This was referenced Oct 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of commits from #3143, including #3120 and #3122.
cc @emersion
Changes
wlr_subsurface.parent_linkis removedInstead, use
wlr_subsurface.current.link; same goes forwlr_subsurface.parent_pending_link.wlr_surface.subsurfaces_{above,below}is moved towlr_surface_stateUse
wlr_surface.current.subsurfaces_{above,below}.