Skip to content

Comments

remove noop backend and noop output#6579

Merged
emersion merged 1 commit intoswaywm:masterfrom
bl4ckb0ne:nuke_noop
Nov 25, 2021
Merged

remove noop backend and noop output#6579
emersion merged 1 commit intoswaywm:masterfrom
bl4ckb0ne:nuke_noop

Conversation

@bl4ckb0ne
Copy link
Contributor

@emersion
Copy link
Member

emersion commented Oct 4, 2021

Well we still need to keep the noop output, but we can replace it with a headless output.

@bl4ckb0ne
Copy link
Contributor Author

Pushed a v2 of the patch. I put 800x600 as the headless output size randomly, let me know if you'd like a different size.

@emersion
Copy link
Member

Hm for some reason the headless output now shows up in swaymsg -t get_outputs. This was not the case for the noop one. It also shows up in wayland-info btw.

Also need to remove #include <wlr/backend/noop.h> from sway/server.c.

@bl4ckb0ne
Copy link
Contributor Author

Is it something we don't want?

@emersion
Copy link
Member

Yeah, we don't want this internal implementation detail to be exposed to our users. Users will be confused if they see this output that isn't supposed to exist.

@emersion
Copy link
Member

I think this happens because the sway_output is enabled for some reason? It shouldn't get enabled.

@emersion
Copy link
Member

Hm maybe this is an issue with wlroots, where wlr_output.enabled == true for headless outputs but not for noop. But I'm confused, I see noop outputs are marked as enabled in wlroots with wlr_output_update_enabled

@bl4ckb0ne bl4ckb0ne force-pushed the nuke_noop branch 2 times, most recently from 99b4d02 to 1533959 Compare November 25, 2021 16:05
@emersion
Copy link
Member

Code LGTM! Can you squash these commits together? Starting Sway with just the first one applied will segfault.

wlroots removed the support for the noop backend. Instead we rely on the
headless backend to provide the fallback output.
@bl4ckb0ne
Copy link
Contributor Author

Done! I also added a bit of explaination in the commit message.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@emersion emersion enabled auto-merge (rebase) November 25, 2021 16:47
@emersion emersion merged commit 0cd8efe into swaywm:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants