Skip to content

Conversation

@duchieu2k
Copy link
Contributor

@duchieu2k duchieu2k commented Jan 26, 2026

Summary by CodeRabbit

  • Chores
    • Deployment templates made CI-aware: when CI mode is active, deployments default to Single mode and cluster configuration is suppressed.
    • Templating logic adjusted to ensure correct rendering and valid deployment manifests when CI mode is enabled.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Walkthrough

Adds CI-aware conditional templating to the ArangoDeployment Helm template: when .Values.global.ci is true, mode is set to Single and the cluster block is omitted; template block endings updated to preserve correct nesting.

Changes

Cohort / File(s) Summary
ArangoDeployment CI-specific template logic
kubernetes/arangodb/templates/arangodeployment.yaml
Sets mode: Single when .Values.global.ci is true via a CI-aware ternary; wraps the cluster rendering with a not .Values.global.ci condition to hide it during CI; adjusts template block closures to match the new conditional structure.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: add CI condition' directly and clearly describes the main change: adding a CI-aware conditional to the ArangoDB deployment template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@kubernetes/arangodb/templates/arangodeployment.yaml`:
- Around line 6-10: Replace the standalone Helm if/else block that emits mode
under spec with a single inline Helm ternary so the YAML stays valid;
specifically remove the block using .Values.global.ci and .Values.mode and set
the mode field to use Helm's ternary (returning "Single" when .Values.global.ci
is true, otherwise .Values.mode) so the template emits a single scalar for mode
in arangodeployment.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants