feature/2 error when using same client id#4
Merged
svnoak merged 2 commits intosvnoak:mainfrom Jul 7, 2025
Merged
Conversation
Owner
4ba45a7 to
716a455
Compare
svnoak
requested changes
Jul 6, 2025
Owner
There was a problem hiding this comment.
Thanks for the PR!
I think it would be best to move the check of existing active websockets and the possible rejection for the given client_id to the ws_handler, before upgrading the connection. That way we wouldn't open and close unnecessary websocket connections for rejected client_ids.
Contributor
Author
Yeah, good point. I'll fix that! |
svnoak
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmtCloses #2