Merged
Conversation
Owner
|
Awesome! I think this looks good. I've created an issue regarding a production ready ASN database, see #23 . |
svnoak
approved these changes
Jul 23, 2025
resolves: svnoak#8
Contributor
Author
|
@svnoak Anything else needed from me on this? :) |
svnoak
approved these changes
Jul 25, 2025
Owner
|
@Joxtacy All good, your PR is merged now ;) |
Contributor
Author
Wohoo! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASN checking
Adds the possibility to register ASNs when setting up a client.
Uses the MaxMind GeoIP ASN database to do the lookups.
This PR adds a test ASN db so that you can at least run things locally.
What's not in this PR
Discussion
To make this production ready, we need to decide on how we handle the actual production database.
I don't really have any suggestions at this point. One brief thought I had was to include it in the docker image, but it's probably just gonna be annoying to build and deploy that every once in a while.