Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Splits main.rs into dedicated modules for improved structure and maintainability.
- Extracts WebSocket handling (
websocket.rs) and HTTP forwarding (forwarding.rs) into separate files. - Introduces a
Configloader (config.rs) and a logging setup module (logging.rs). - Refactors
AppStateinitialization and moves access control logic into its own module.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/websocket.rs | New module for WebSocket upgrade and session handling |
| server/src/forwarding.rs | New module for HTTP request forwarding logic |
| server/src/models.rs | Extracted shared request/response data structures |
| server/src/config.rs | Added Config struct to centralize environment variable loading |
| server/src/logging.rs | Added setup_tracing() for environment-aware logging |
| server/src/access_control.rs | New module for client authentication checks |
| server/src/main.rs | Updated imports, routing setup, and initialization calls |
| Cargo.toml | Enabled JSON output feature for tracing-subscriber |
Comments suppressed due to low confidence (2)
server/src/config.rs:13
- [nitpick] This reads
IS_PRODUCTION, butlogging.rschecksAPP_ENV. Consider unifying on a single environment variable name to avoid confusion.
let is_production = env::var("IS_PRODUCTION")
server/src/forwarding.rs:16
- The forwarding logic is critical but has no accompanying tests. Consider adding unit or integration tests for
handle_forwarding_requestto verify correct behavior.
pub async fn handle_forwarding_request(
| break; | ||
| } | ||
| } | ||
| Some(Ok(msg)) = socket.recv() => { |
There was a problem hiding this comment.
The Err variant from socket.recv() is silently ignored, exiting the loop without logging. Consider matching Some(Err(e)) to log receive errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting up main.rs into modules for better maintainability of the project.