You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder if we should generalise this, so that we use the PR for Svelte and Kit types as well? This is a frequent nuisance on those repos
Good idea! Done.
Added post_clone for svelte and kit that patches node_modules/<pkg>/types/ with the cloned repo's types dir. Since both repos commit types/index.d.ts -> no build is needed. Just copying the types/ folder is enough for twoslash to resolve mports against the PR branch. right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@sveltejs/sv-utilstypes support for twoslash hover info in cli docs.pnpm install && pnpm buildon the cli repo so.d.mtstypes are generatedsvand@sveltejs/sv-utilsinnode_modulesto the cloned repo so twoslash resolves PR branch types@sveltejs/sv-utilsto twoslash compiler typesRelated: sveltejs/cli#997