Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/deep-set-nullish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: prevent `deep_set` crash on nullish nested values
4 changes: 2 additions & 2 deletions packages/kit/src/runtime/form-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -466,8 +466,8 @@ export function deep_set(object, keys, value) {
check_prototype_pollution(key);

const is_array = /^\d+$/.test(keys[i + 1]);
const exists = Object.hasOwn(current, key);
const inner = current[key];
const inner = Object.hasOwn(current, key) ? current[key] : undefined;
const exists = inner != null;

if (exists && is_array !== Array.isArray(inner)) {
throw new Error(`Invalid array key ${keys[i + 1]}`);
Expand Down
16 changes: 16 additions & 0 deletions packages/kit/src/runtime/form-utils.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -425,4 +425,20 @@ describe('deep_set', () => {
// @ts-ignore
expect(Object.prototype.toString.property).toBeUndefined();
});

test('creates nested object when intermediate value is undefined', () => {
const target = { nested: undefined };

deep_set(target, ['nested', 'name'], 'hello');

expect(target).toEqual({ nested: { name: 'hello' } });
});

test('creates nested object when intermediate value is null', () => {
const target = { nested: null };

deep_set(target, ['nested', 'name'], 'hello');

expect(target).toEqual({ nested: { name: 'hello' } });
});
});
Loading