feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
Merged
feat: deprecate adapter-cloudflare-workers in favour of adapter-cloudflare#13634
adapter-cloudflare-workers in favour of adapter-cloudflare#13634Conversation
added 3 commits
March 24, 2025 17:56
🦋 Changeset detectedLatest commit: 49d28e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Mar 24, 2025
benmccann
reviewed
Mar 24, 2025
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
6 tasks
benmccann
reviewed
Mar 25, 2025
benmccann
reviewed
Mar 25, 2025
Contributor
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Great stuff! I love seeing a single adapter that chooses workers or pages for you based on the config file! 🫶
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Member
Author
|
Thanks for the feedback guys. I've updated the docs and also bumped the minimum Wrangler version to v4. I've also updated the fallback option to work with Cloudflare Workers if the user has configured the assets 404-handling option. EDIT: I've also added some simple tests to check that the build output is successful and works with the pages/workers dev environment provided by wrangler. |
added 5 commits
March 26, 2025 11:48
benmccann
approved these changes
Mar 28, 2025
Merged
This was referenced Apr 2, 2025
4 tasks
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
…oudflare` (sveltejs#13634) * merge adapters * changeset * it's valid to not specify a main entry if the user is only deploying static assets * format * adjust docs * also use cf pages env var * fix migration guide link * try to fix doc build error * Update index.d.ts Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * Update kind-carrots-deliver.md Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * validate assets key if main key is set * delete adapter-cloudflare-workers * adjust docs and workspace for removing cloudflare workers * fix docs title * clarify _routes.json belongs to cloudflare pages * Update packages/adapter-cloudflare/src/worker.js Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * changes according to feedback * revert type change * fix lock file * fixes * tests * fix lockfile * format --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an alternative that closes #13427
closes #13360
closes #13071
closes #13005
closes #12813
closes #13579
closes #10924
This PR adds a deprecation notice to the
adapter-cloudflare-workersdocs while adding support for Cloudflare Workers Static Assets by skipping Cloudflare Pages-specific build steps and respecting Wrangler configuration settings if building for Cloudflare Workers Static Assets.We use a heuristic to guess whether we're building for Cloudflare Pages or Workers based on the Wrangler configuration file settings, but even if there is no Wrangler configuration file, the build output is compatible with both platforms.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits