fix(eslint): account for all config formats#994
Conversation
🦋 Changeset detectedLatest commit: 4074d63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
manuel3108
left a comment
There was a problem hiding this comment.
Which problem exactly are you trying to solve in this file? https://github.com/hyunbinseo/svelte-kit-templates/blob/b200ae76d7bb2c61e6e695c4d90912666d39256c/javascript/eslint.config.js I don't think im following currently.
Don't mind the comments below, it's just so that we don't forget about them.
The original only partially supported the following cases, |
jycouet
left a comment
There was a problem hiding this comment.
I didn't get what is the root cause of this PR?
|
Not too familiar with the AST, cannot move the comment inside the object. |
Nah, I don't manage too. Let me know |
I spotted the problem when looking at https://github.com/hyunbinseo/svelte-kit-templates/blob/b200ae76d7bb2c61e6e695c4d90912666d39256c/javascript/eslint.config.js. I had to test eslint by hand.
We should add a test, could someone lend me hand?
That repo was quite helpful, maybe we can expand on the templates we take snapshots for?