Conversation
🦋 Changeset detectedLatest commit: 0dd5c54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
Gah — lint is failing because of Prettier, but if I run Prettier then the tests fail. Seems there are conflicting configs somewhere? |
Member
After the prettier format, the failing test is just a snapshot whose difference is formatting: Error: Snapshot `cli > should create a new project with name 'create-only' > file "svelte.config.js" does not match snapshot 1` mismatched
- /packages/sv/src/cli/tests/cli.ts:116:5
- Expected
+ Received
@@ -2,11 +2,11 @@
/** @type {import('@sveltejs/kit').Config} */
const config = {
compilerOptions: {
// Force runes mode for the project, except for libraries. Can be removed in svelte 6.
- runes: ({ filename }) => filename.split(/[/\\]/).includes('node_modules') ? undefined : true
+ runes: ({ filename }) => (filename.split(/[/\\]/).includes('node_modules') ? undefined : true)
},
kit: {
// adapter-auto only supports some environments, see https://svelte.dev/docs/kit/adapter-auto for a list.
// If your environment is not supported, or you settled on a specific environment, switch out the adapter.
// See https://svelte.dev/docs/kit/adapters for more information about adapters.Should just need a snapshot update after the prettier format run. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current
runesoption feels very elaborate, and makessvelte.config.jsunnecessarily intimidating. I don't think we need to care about making the path relative (if you're building your app insidenode_modules, then a) you're an extreme edge case and b) all that will happen isrunesbecomesundefined, harmlessly) or making it lowercase (if someone has aNODE_MODULESfolder then they will have far more severe self-inflicted wounds than this).We can make it a simple one-liner instead
Checklist