Skip to content

feat: decouple pnpmBuildDependency from sv#1035

Merged
jycouet merged 1 commit intomainfrom
pnpmBuildDependency
Apr 3, 2026
Merged

feat: decouple pnpmBuildDependency from sv#1035
jycouet merged 1 commit intomainfrom
pnpmBuildDependency

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented Apr 3, 2026

Closes #1030

Description

replacing

run: ({ sv }) => {
  sv.pnpmBuildDependency('my-native-dep');
}

by

import { pnpm } from '@sveltejs/sv-utils';

run: ({ sv, packageManager }) => {
  if (packageManager === 'pnpm') {
    sv.file(file.findUp('pnpm-workspace.yaml'), pnpm.onlyBuiltDependencies('my-native-dep'));
  }
}

DX is not the best, but sv is less dependant of pnpm & changes.
@benmccann WDYT?

Checklist

  • Update snapshots (if applicable)
  • Add a changeset (if applicable)
  • Allow maintainers to edit this PR
  • I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 3, 2026

🦋 Changeset detected

Latest commit: 36578be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
sv Minor
@sveltejs/sv-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jycouet jycouet marked this pull request as draft April 3, 2026 22:41
@jycouet jycouet merged commit 36578be into main Apr 3, 2026
5 of 7 checks passed
@jycouet jycouet deleted the pnpmBuildDependency branch April 3, 2026 22:42
@github-actions github-actions bot mentioned this pull request Apr 3, 2026
@svelte-docs-bot
Copy link
Copy Markdown

@jycouet jycouet restored the pnpmBuildDependency branch April 3, 2026 22:48
@jycouet
Copy link
Copy Markdown
Contributor Author

jycouet commented Apr 3, 2026

I did something WRONG! it should not have been merged! :o
I removed it from main. And I will do another PR. but not now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sv API & pnpmBuildDependency

1 participant