Skip to content

fix(eslint): account for all config formats #2908

fix(eslint): account for all config formats

fix(eslint): account for all config formats #2908

Triggered via pull request March 28, 2026 13:16
Status Failure
Total duration 5m 14s
Artifacts

ci.yml

on: pull_request
Matrix: test
preview-release
20s
preview-release
Fit to window
Zoom out
Zoom in

Annotations

6 errors, 6 warnings, and 1 notice
test (ubuntu-latest)
Process completed with exit code 1.
[cli] tests/cli.ts > cli > should create a new project with name 'create-with-all-addons': packages/sv/src/cli/tests/cli.ts#L116
Error: Snapshot `cli > should create a new project with name 'create-with-all-addons' > file "src/routes/demo/better-auth/login/+page.server.ts" does not match snapshot 1` mismatched - Expected + Received @@ -12,12 +12,12 @@ }; export const actions: Actions = { signInEmail: async (event) => { const formData = await event.request.formData(); - const email = (formData.get('email') ?? '') as string; + const email = typeof formData.get('email') === 'string' ? formData.get('email') : ''; - const password = (formData.get('password') ?? '') as string; + const password = typeof formData.get('password') === 'string' ? formData.get('password') : ''; try { await auth.api.signInEmail({ body: { email, @@ -34,13 +34,13 @@ return redirect(302, '/demo/better-auth'); }, signUpEmail: async (event) => { const formData = await event.request.formData(); - const email = (formData.get('email') ?? '') as string; + const email = typeof formData.get('email') === 'string' ? formData.get('email') : ''; - const password = (formData.get('password') ?? '') as string; + const password = typeof formData.get('password') === 'string' ? formData.get('password') : ''; - const name = (formData.get('name') ?? '') as string; + const name = typeof formData.get('name') === 'string' ? formData.get('name') : ''; try { await auth.api.signUpEmail({ body: { email, @@ -58,12 +58,13 @@ return redirect(302, '/demo/better-auth'); }, signInSocial: async (event) => { const formData = await event.request.formData(); - const provider = (formData.get('provider') ?? 'github') as string; + + const provider = typeof formData.get('provider') === 'string' ? formData.get('provider') : 'github'; - const callbackURL = (formData.get('callbackURL') ?? '/demo/better-auth') as string; + const callbackURL = typeof formData.get('callbackURL') === 'string' ? formData.get('callbackURL') : '/demo/better-auth'; const result = await auth.api.signInSocial({ body: { provider: provider as "github", callbackURL ❯ tests/cli.ts:116:5
test (windows-latest)
The strategy configuration was canceled because "test.ubuntu-latest" failed
test (windows-latest)
The operation was canceled.
test (macOS-latest)
The strategy configuration was canceled because "test.ubuntu-latest" failed
test (macOS-latest)
The operation was canceled.
check
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
lint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
preview-release
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
test (ubuntu-latest)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
test (windows-latest)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
test (macOS-latest)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
preview-release
{ "workflowData": { "owner": "sveltejs", "repo": "cli", "sha": "21e3b26accecf93a49af0230c77d9c41f2be09c2", "ref": "994" }, "key": "rl5hgCvfAE", "runId": 23686024310, "webhookDebug": { "action": "requested", "head_branch": "shaky-barnacle", "head_repository_full_name": "sacrosanctic/cli", "full_name": "sveltejs/cli", "isPullRequest": true, "prNumber": 994, "prNumberType": "number", "isNewPullRequest": true, "isOldPullRequest": false, "prKey": "sacrosanctic/cli:shaky-barnacle", "oldPrDataHash": "2USTLz0iSq", "lookupKey": "sacrosanctic/cli:shaky-barnacle", "data": { "owner": "sveltejs", "repo": "cli", "sha": "21e3b26accecf93a49af0230c77d9c41f2be09c2", "ref": "994" } } }