-
Notifications
You must be signed in to change notification settings - Fork 24
FENDL 2 vs 3 Comparisons #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gonuke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eitan-weinstein - these kinds of visualizations will be helpful to think through what's changed, etc.
tools/ALARAJOYWrapper/fendl_2vs3.csv
Outdated
| @@ -0,0 +1,2922 @@ | |||
| ,Isotope,Parent KZA,Number of Reactions (FENDL2),Number of Reactions (FENDL3) | |||
| 0,H-001,10010,1.0, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to put a 0.0 for entries where there are no reactions to make sure we get the column ordering right. I'm a little skeptical at the number of entries that appear to have non-zero reactions in FENDL2 and no entry for FENDL3 here???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll change it from NaN to 0.0.
The reason for a lot of the missing entries in FENDL3 is that the TENDL2017 neutron database for them have only the TENDL file, but not the additional required PENDF file, so GROUPR cannot convert them to groupwise data.
e.g. 1H:
https://tendl.web.psi.ch/tendl_2017/neutron_html/H/NeutronH01.html
|
As a follow up to @bohmt 's comparison of the single element response between ALARA with FENDL2 against FISPACT-II for the irradiation of elemental iron, I've used the comparison tool in progress from #144 to include a plot for ALARA with ALARAJOY-processed FENDL3 data.
As can be seen above, ALARA with ALARAJOY-processed FENDL3 has much greater agreement with FISPACT-II than ALARA with FENDL2 at 100 years, in part due to the lower tritium production that we've been seeing from ALARAJOY. If we are to be validating against FISPACT-II, perhaps this suggests that FENDL2's tritium production values are a meaningful overrepresentation, and the lessened values from ALARAJOY-FENDL3 is a valuable correction. Otherwise, in the shorter cooling times, there is a slightly higher total activity from ALARAJOY-FENDL3, which will be interesting to see if it appears across the board for other elements, or is unique to this case. I'm going to start working on a tool to add to |

Closes #81 .
This PR adds a CSV containing every isotope/isomer available in either FENDL2 or FENDL3 data, with the number of reactions per isotope listed for each row. Additionally, I included a histogram comparing the distributions of reactions per parent across the two datasets. The inclusion of this data will be informative to the users of
ALARAJOYWrapperof the motivation of upgrading to FENDL3, given the much larger scope of the new data.A summary of the differences between FENDL3 vs FENDL2 is listed below (updated following changes in #125 ):